[PATCH] D63841: [GWP-ASan] Add generic unwinders and structure backtrace output.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added a comment.

I'm not very familiar with the compiler-rt build-side of this change, eugenis can speak to that better than I can.



================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp:114
+  Backtrace = Opts.Backtrace;
+  PrintBacktrace = Opts.PrintBacktrace;
 
----------------
Instead of doing if (PrintBacktrace) {} else {} checks everywhere why not just set it to the default value here if it's null?


================
Comment at: compiler-rt/lib/gwp_asan/optional/backtrace_sanitizer_common.cpp:32
+  Trace.Reset();
+  assert(Size <= __sanitizer::kStackTraceMax &&
+         "GWP-ASan asking for higher stack depth than supported by "
----------------
Why not std::min() instead of assert(), otherwise all backtrace implementations are beholden to __sanitizer::kStackTraceMax


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63841/new/

https://reviews.llvm.org/D63841