[PATCH] D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

Most of my concerns have already been noted by other reviewers, in particular with regards to error handling. Just a small nit inline.



================
Comment at: lib/DebugInfo/GSYM/FileWriter.cpp:39
+  const uint16_t Swapped = support::endian::byte_swap(U, ByteOrder);
+  return writeData(ArrayRef<uint8_t>((const uint8_t *)&Swapped, sizeof(Swapped))); 
+}
----------------
You're already using static_cast etc, so let's use `reinterpret_cast` here? Applies to the rest of the review as well. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63828/new/

https://reviews.llvm.org/D63828