[PATCH] D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 27 10:10:14 PDT 2019
compnerd added a comment.
I don't understand the change for the `PRIVATE` to `PUBLIC`. That doesn't make a different to the import library handling, which is baked right into CMake, so that will always be handled properly irrespective of the link dependency's visibility. I think the only thing that may be needed is the Core dependency on the TestPlugin.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63881/new/
https://reviews.llvm.org/D63881
More information about the llvm-commits
mailing list