[PATCH] D63518: BitStream reader: propagate errors

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 09:27:17 PDT 2019


jfb marked 2 inline comments as done.
jfb added a subscriber: hans.
jfb added inline comments.


================
Comment at: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp:205
+      return MaybeBitCode.takeError();
+    switch (unsigned BitCode = MaybeBitCode.get()) {
     default: // Default behavior: reject
----------------
abrachet wrote:
> This and an identical switch on line 5367 cause an unused variable warning from this commit. I don't know if the build bots report on this, or the proper way to tell you about this but hopefully you will see it :)
Thanks, looks like @Hans fixed it in r364505. Odd that it wasn't warning locally for me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63518/new/

https://reviews.llvm.org/D63518





More information about the llvm-commits mailing list