[PATCH] D62653: [Mips][DSP] Fix physregs incorrectly marked as dead.
Mirko Brkusanin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 27 09:11:28 PDT 2019
mbrkusanin marked an inline comment as done.
mbrkusanin added inline comments.
================
Comment at: lib/Target/Mips/MipsSEISelDAGToDAG.cpp:158
+ Reg = MipsRegisterInfo::getDSPOutFlagIfSubreg(Reg);
+ MO.setIsDead();
+ DeadImplRegs[Reg] = &MO;
----------------
efriedma wrote:
> Does this setIsDead() call actually run for some testcase? I don't see any dead flag in your testcase.
You're right. We don't need it anymore. This was needed in an older version of the patch. Now we can just check if it's dead.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62653/new/
https://reviews.llvm.org/D62653
More information about the llvm-commits
mailing list