[PATCH] D62818: [InstCombine] Introduce fold for icmp pred (and X, (sh signbit, Y)), 0.

[Roman Lebedev via llvm-commits]

Thanks!
Patch needs a rebase then.

On Thu, Jun 27, 2019 at 5:27 PM Sanjay Patel via Phabricator
<reviews at reviews.llvm.org> wrote:
>
> spatel added inline comments.
>
>
> ================
> Comment at: llvm/test/Transforms/InstCombine/onehot_merge.ll:18
>  ;CHECK: @foo1_and
> -;CHECK:  shl i32 1, %c1
> -;CHECK-NEXT:  lshr i32 -2147483648, %c2
> ----------------
> lebedev.ri wrote:
> > lebedev.ri wrote:
> > > lebedev.ri wrote:
> > > > Can you please regenerate the original test?
> > > I'm not sure what's on the LHS of the diff, but ignoring the instruction count this looks like improvement to me.
> > AH, you also want to str-replace `%tmp` with `%t`, it confuses the update script likely.
> rL364546
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D62818/new/
>
> https://reviews.llvm.org/D62818
>
>
>