[PATCH] D63811: [IR][Patternmatch] Add m_SpecificInt_ULT() predicate

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 08:17:08 PDT 2019


lebedev.ri added a comment.

In D63811#1560875 <https://reviews.llvm.org/D63811#1560875>, @spatel wrote:

> LGTM


Thank you for the review.

> not sure if it's worth generalizing or a TODO comment, but we could take a predicate as a parameter (rather than hard-coding 'ULT') and switch the APInt compare method based on that?

Do yo propose passing `ICmpInst::Predicate`?
I did briefly think about it, and wasn't sure it's worth it *yet*.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63811/new/

https://reviews.llvm.org/D63811





More information about the llvm-commits mailing list