[PATCH] D63814: [TableGen] Allow DAG isel patterns to override default operands.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 06:16:01 PDT 2019


simon_tatham updated this revision to Diff 206846.
simon_tatham added a comment.

Changed my mind about the opt-in system: instead of using a subclass of `OperandWithDefaultOps`, I've switched to using a flag field inside the existing class.

That should make it easier for a back end to define some flags one way and some another. And if people ever want to switch the default over to permitting overrides, and have a small number of back ends //unset// the same flag, it will be easier this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63814/new/

https://reviews.llvm.org/D63814

Files:
  llvm/include/llvm/Target/Target.td
  llvm/test/TableGen/DAGDefaultOps.td
  llvm/utils/TableGen/CodeGenDAGPatterns.cpp
  llvm/utils/TableGen/CodeGenDAGPatterns.h
  llvm/utils/TableGen/DAGISelMatcherGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63814.206846.patch
Type: text/x-patch
Size: 7645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190627/2ed02616/attachment.bin>


More information about the llvm-commits mailing list