[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

For information, I had to roll this back at it breaks sanitizers. Sanitizer passes insert some nobuiltin attributes on all memcmp calls to prevent expansion and still be able to intercept them (`maybeMarkSanitizerLibraryCallNoBuiltin`), and these passes are added last in opt:

  PMBuilder.addExtension(PassManagerBuilder::EP_OptimizerLast, addMemorySanitizerPass);

so they now run after `ExpandMemCmp`.

The fix would be to move `addMemcmpPasses(MPM);` after `addExtensionsToPM(EP_ScalarOptimizerLate, MPM);`. I'll do this after I get the test-suite benchmarks in, so that we can validate the interactions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60318/new/

https://reviews.llvm.org/D60318