[PATCH] D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty.

Thu Jun 27 05:08:22 PDT 2019

grimar added a comment.

In D63869#1560610 <https://reviews.llvm.org/D63869#1560610>, @ikudrin wrote:

> - Reworked the test. I am not sure about moving it into `linkerscript`, though, because it does not test the support for linker scripts per se.

Actually `.rela.plt` is kept only because it is mentioned in a linker script. It is relative.

> Moreover, there are lots of tests in the main test folder which also use linker scripts.

And most of them are initially placed there by mistake it seems. Also, I found no other `.test` files that are based on linker script in that folder.
(`.test` files I see are YAML based and all linker script based test still lives in ELF/linkerscript).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63869/new/

https://reviews.llvm.org/D63869