[PATCH] D63862: [ARM] Tighten restrictions on use of SP in v8.1-M CSEL.

Thu Jun 27 04:58:32 PDT 2019

simon_tatham marked an inline comment as done.
simon_tatham added inline comments.

================
Comment at: llvm/test/MC/Disassembler/ARM/thumbv8.1m.s:1
-# RUN: llvm-mc -disassemble -triple=thumbv8.1m.main-none-eabi -show-encoding %s 2> %t | FileCheck %s
+# RUN: not llvm-mc -disassemble -triple=thumbv8.1m.main-none-eabi -show-encoding %s 2> %t | FileCheck %s
 # RUN: FileCheck --check-prefix=ERROR < %t %s
----------------
DavidSpickett wrote:
> How did this work to begin with?
No test in this file previously generated the message "warning: invalid instruction encoding". Two of the new ones do.

Apparently that message, representing `MCDisassembler::Fail` as opposed to `SoftFail`, causes the exit status of `llvm-mc` to become failure, in spite of the word "warning" on the front!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63862/new/

https://reviews.llvm.org/D63862