[PATCH] D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/empty-relaplt-dyntags.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
----------------
This test should probably be moved to linkerscript/


================
Comment at: test/ELF/empty-relaplt-dyntags.s:5
+# RUN: echo "PHDRS { \
+# RUN:  all PT_LOAD; \
+# RUN:  dyn PT_DYNAMIC; \
----------------
Nit: indent the string literal so that `S` in `SECTIONS` does not occupy the same column of `e` in `echo`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63869/new/

https://reviews.llvm.org/D63869