[PATCH] D63863: [ARM] Make coprocessor number restrictions consistent.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 02:50:12 PDT 2019


simon_tatham created this revision.
simon_tatham added reviewers: DavidSpickett, ostannard.
Herald added subscribers: llvm-commits, hiraditya, kristof.beyls, javed.absar.
Herald added a project: LLVM.

Different versions of the Arm architecture disallow the use of generic
coprocessor instructions like MCR and CDP on different sets of
coprocessors. This commit centralises the check of the coprocessor
number so that it's consistent between assembly and disassembly, and
also updates it for the new restrictions in Arm v8.1-M.

New tests added that check all the coprocessor numbers; old tests
updated, where they used a number that's now become illegal in the
context in question.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63863

Files:
  llvm/lib/Target/ARM/ARMBaseInstrInfo.h
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
  llvm/test/MC/ARM/coprocessors.s
  llvm/test/MC/ARM/diagnostics.s
  llvm/test/MC/ARM/thumb2-diagnostics.s
  llvm/test/MC/ARM/v8_IT_manual.s
  llvm/test/MC/Disassembler/ARM/coprocessors-arm.txt
  llvm/test/MC/Disassembler/ARM/coprocessors-thumb.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63863.206805.patch
Type: text/x-patch
Size: 75424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190627/10ba43dc/attachment.bin>


More information about the llvm-commits mailing list