[PATCH] D63521: Teach the symbolizer lib symbolize objects directly.

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 23:40:14 PDT 2019


ychen added a comment.

I don't think it's a loss of functionality versus the previous version which creates `DWARFContext ` even for COFF object (not work obviously). This version still does not work for COFF archive but looks a little bit more reasonable. IMHO, we should have no or all support for COFF archive, not partial support. I could either

1. Land the previous version (with the additional check for COFF so users are notified of the lack of support) and revisit COFF archive support later.
2. Support COFF archive file in this patch with the necessary tests.

I would prefer the first choice since one patch for each makes more sense. @MaskRay @jhenderson thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63521/new/

https://reviews.llvm.org/D63521





More information about the llvm-commits mailing list