[PATCH] D63838: [ARM] MVE loads and stores

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13195
+  auto Ty = VT.getSimpleVT().SimpleTy;
+  bool Allowed = false;
+
----------------
Why has Allowed been introduced? Looks like we can still just return.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13217
+
+  if (Ty == MVT::v16i8 || Ty == MVT::v8i16 || Ty == MVT::v8f16 ||
+      Ty == MVT::v4i32 || Ty == MVT::v4f32 || Ty == MVT::v2i64 ||
----------------
nit: reduce indentation and early exit instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63838/new/

https://reviews.llvm.org/D63838