[PATCH] D63104: Add GSYM utility files along with unit tests.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 22:55:38 PDT 2019


thakis added a comment.

The test binary looks like it has many dependencies it doesn't actually need:



================
Comment at: llvm/trunk/unittests/DebugInfo/GSYM/CMakeLists.txt:2
+set(LLVM_LINK_COMPONENTS
+  ${LLVM_TARGETS_TO_BUILD}
+  AsmPrinter
----------------
This looks unused?


================
Comment at: llvm/trunk/unittests/DebugInfo/GSYM/CMakeLists.txt:3
+  ${LLVM_TARGETS_TO_BUILD}
+  AsmPrinter
+  DebugInfoGSYM
----------------
This, too.


================
Comment at: llvm/trunk/unittests/DebugInfo/GSYM/CMakeLists.txt:5
+  DebugInfoGSYM
+  MC
+  Object
----------------
As does this.


================
Comment at: llvm/trunk/unittests/DebugInfo/GSYM/CMakeLists.txt:6
+  MC
+  Object
+  ObjectYAML
----------------
And this.


================
Comment at: llvm/trunk/unittests/DebugInfo/GSYM/CMakeLists.txt:7
+  Object
+  ObjectYAML
+  Support
----------------
And this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63104/new/

https://reviews.llvm.org/D63104





More information about the llvm-commits mailing list