[llvm] r364497 - [InstCombine][NFCI] Fix test comments.

Huihui Zhang via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 22:46:06 PDT 2019


Author: huihuiz
Date: Wed Jun 26 22:46:06 2019
New Revision: 364497

URL: http://llvm.org/viewvc/llvm-project?rev=364497&view=rev
Log:
[InstCombine][NFCI] Fix test comments.

For fold
(X & (signbit l>> Y)) ==/!= 0 -> (X << Y) >=/< 0
(X & (signbit << Y)) ==/!= 0 -> (X l>> Y) >=/< 0

Test cases of X being constant are positive tests not negative.

Prep work for D62818.

Modified:
    llvm/trunk/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll
    llvm/trunk/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll

Modified: llvm/trunk/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll?rev=364497&r1=364496&r2=364497&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/signbit-lshr-and-icmpeq-zero.ll Wed Jun 26 22:46:06 2019
@@ -183,8 +183,6 @@ define i1 @scalar_i32_signbit_lshr_and_e
   ret i1 %r
 }
 
-; Negative tests
-
 ; X is constant
 
 define i1 @scalar_i32_signbit_lshr_and_eq_X_is_constant1(i32 %y) {
@@ -211,6 +209,8 @@ define i1 @scalar_i32_signbit_lshr_and_e
   ret i1 %r
 }
 
+; Negative tests
+
 ; Check 'slt' predicate
 
 define i1 @scalar_i32_signbit_lshr_and_slt(i32 %x, i32 %y) {

Modified: llvm/trunk/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll?rev=364497&r1=364496&r2=364497&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/signbit-shl-and-icmpeq-zero.ll Wed Jun 26 22:46:06 2019
@@ -183,8 +183,6 @@ define i1 @scalar_i32_signbit_shl_and_eq
   ret i1 %r
 }
 
-; Negative tests
-
 ; X is constant
 
 define i1 @scalar_i32_signbit_shl_and_eq_X_is_constant1(i32 %y) {
@@ -213,6 +211,8 @@ define i1 @scalar_i32_signbit_shl_and_eq
   ret i1 %r
 }
 
+; Negative tests
+
 ; Check 'slt' predicate
 
 define i1 @scalar_i32_signbit_shl_and_slt(i32 %x, i32 %y) {




More information about the llvm-commits mailing list