[PATCH] D63844: [LoopFusion] Extend use of OptimizationRemarkEmitter

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 16:01:30 PDT 2019


jdoerfert added a comment.

I went over the whole patch, except a small detail this all looks perfectly fine to me. Given that still want to "flesh out details" I will wait with a final review but I do not expect a problem.



================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:1173
+             << Stat.getDesc());
+  }
 };
----------------
I would somehow prefer if the two functions above were merged or at least one uses the other. The ORE part is almost identical and we could, probably should, increment the relevant statistic in `reportLoopFusion` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63844/new/

https://reviews.llvm.org/D63844





More information about the llvm-commits mailing list