[PATCH] D63629: [JumpThreading][PR42085] Fold constant TIs before calculating LoopHeaders

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 15:31:48 PDT 2019


efriedma added a comment.

> there is a possibility of a miscompile when threading an edge across the LH

How do we actually get a miscompile?  The reason we don't thread across loop headers is to promote later loop optimizations, not because threading across loop headers is unsound.  In general, we have to support irreducible CFGs, and I'm worried this fix is covering up a bug in our handling of such code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63629/new/

https://reviews.llvm.org/D63629





More information about the llvm-commits mailing list