[PATCH] D63842: [PGO] Update ICP pass for recent byval type changes

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CallPromotionUtils.cpp:419-420
+      if (ArgAttrs.getByValType())
+        ArgAttrs.addByValAttr(cast<PointerType>(FormalTy)->getElementType());
+
       NewArgAttrs.push_back(AttributeSet::get(Ctx, ArgAttrs));
----------------
It'd be better if we could copy/paste the source byval type.

We'd probably have to handle an unspecified byval type anyway; but it's the difference between code that will carry on working forever and we can prune later, and code that will need modifying again before opaque pointers are a thing.

I'm not asking you to do this, Reid; it's late here but I'll try to come up with a concrete diff tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63842/new/

https://reviews.llvm.org/D63842