[PATCH] D63305: Propagate Trip count Assumptions to runtime check

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:202-203
+    CleanRTC("polly-clean-rtc",
+             cl::desc("Propagate parameter restrictions form Avoid Single"
+                      " Iteration assumptions to overflow check"),
+             cl::Hidden, cl::ZeroOrMore, cl::init(false),
----------------
[type] first letter case: Avoid, Single, Iteration


================
Comment at: lib/Analysis/ScopInfo.cpp:3043-3045
+    InvalidContext = InvalidContext.intersect_params(RestrictDomainParams)
+                        .coalesce()
+                        .gist_params(RestrictDomainParams);
----------------
[suggestion] This seem to be useful enough to be enabled by default and outside of `enforceAssumptionsForAvoidsingleIter` since it is unrelated.


================
Comment at: test/ScopDetect/model-dowhile-update-rtc.ll:3
+
+; RUN: opt %loadPolly -S -O3 -debug-only=polly-ast -debug-only=polly-scops\
+; RUN: -polly-ast -polly-avoid-singular-loops=true -polly-clean-rtc=false\
----------------
`-S` has no effect with `--disable-output`. 

[serious] Is `-O3` should not be necessary either; if some transformation is required by `-polly-ast`, it should be baked-into the test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63305/new/

https://reviews.llvm.org/D63305