[PATCH] D63833: [wasm-ld] Add __global_base symbol to mark the value of --global-base

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 12:53:52 PDT 2019


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/wasm/global-base.test:1
+; RUN: llc -filetype=obj %p/Inputs/start.ll -o %t.o
+
----------------
Can can remove all the leaving `; ` not too.

Still lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63833/new/

https://reviews.llvm.org/D63833





More information about the llvm-commits mailing list