[PATCH] D63836: [llvm-ar] Document response file support in --help

[Sam Clegg via Phabricator via llvm-commits]

sbc100 created this revision.
Herald added subscribers: llvm-commits, rupprecht, aheejin.
Herald added a project: LLVM.

Also a test for this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63836

Files:
  llvm/test/tools/llvm-ar/response-file.test
  llvm/test/tools/llvm-nm/X86/importlibrary.test
  llvm/test/tools/llvm-nm/X86/response-file.test
  llvm/tools/llvm-ar/llvm-ar.cpp


Index: llvm/tools/llvm-ar/llvm-ar.cpp
===================================================================
--- llvm/tools/llvm-ar/llvm-ar.cpp
+++ llvm/tools/llvm-ar/llvm-ar.cpp
@@ -78,6 +78,7 @@
   --plugin=<string>     - Ignored for compatibility
   --help                - Display available options
   --version             - Display the version of this program
+  @<file>               - read options from <file>
 
 OPERATIONS:
   d - delete [files] from the archive
Index: llvm/test/tools/llvm-nm/X86/response-file.test
===================================================================
--- llvm/test/tools/llvm-nm/X86/response-file.test
+++ llvm/test/tools/llvm-nm/X86/response-file.test
@@ -1,5 +1,5 @@
-# RUN: echo "-P %p/Inputs/hello.obj.elf-x86_64" > %t-response
-# RUN: llvm-nm @%t-response | FileCheck %s
+RUN: echo "-P %p/Inputs/hello.obj.elf-x86_64" > %t-response
+RUN: llvm-nm @%t-response | FileCheck %s
 
 CHECK: main T 0 15
 CHECK: puts U 0 0
Index: llvm/test/tools/llvm-nm/X86/importlibrary.test
===================================================================
--- llvm/test/tools/llvm-nm/X86/importlibrary.test
+++ llvm/test/tools/llvm-nm/X86/importlibrary.test
@@ -1,4 +1,4 @@
-# RUN: llvm-nm -B %S/Inputs/example.lib | FileCheck --match-full-lines %s
+RUN: llvm-nm -B %S/Inputs/example.lib | FileCheck --match-full-lines %s
 
 CHECK: 00000000 I __IMPORT_DESCRIPTOR_example
 CHECK: 00000000 I __NULL_IMPORT_DESCRIPTOR
Index: llvm/test/tools/llvm-ar/response-file.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-ar/response-file.test
@@ -0,0 +1,9 @@
+RUN: touch %t-a.txt %t-b.txt %t-c.txt
+RUN: echo "rcs %t.a %t-a.txt %t-b.txt %t-c.txt" > %t-response
+RUN: rm -f %t.a
+RUN: llvm-ar @%t-response
+RUN: llvm-ar t %t.a | FileCheck %s
+
+CHECK:      a.txt
+CHECK-NEXT: b.txt
+CHECK-NEXT: c.txt


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63836.206722.patch
Type: text/x-patch
Size: 1877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190626/5b61051d/attachment.bin>