[PATCH] D63389: [IDF] Generalize IDFCalculator to be used with Clang's CFG

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

Looks good now. I added a few nits inline.



================
Comment at: llvm/include/llvm/Analysis/IteratedDominanceFrontier.h:84
+  ChildrenTy Ret;
+  for (auto Pair : children<SnapShotBBPair>({GD, N}))
+    Ret.emplace_back(Pair.second);
----------------
Since there's no move, I'd rather make it `const &`.



================
Comment at: llvm/include/llvm/Analysis/IteratedDominanceFrontier.h:85
+  for (auto Pair : children<SnapShotBBPair>({GD, N}))
+    Ret.emplace_back(Pair.second);
+  return Ret;
----------------
Is it possible to rename Pair such that it's clear what (type) .second is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63389/new/

https://reviews.llvm.org/D63389