[PATCH] D63812: [InstCombine] Shift amount reassociation (PR42391)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 10:14:46 PDT 2019


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineShifts.cpp:37
+  // The shift opcodes must be identical.
+  Instruction::BinaryOps ShitOpcode = OuterShift->getOpcode();
+  if (ShitOpcode != cast<Instruction>(OuterShift->getOperand(0))->getOpcode())
----------------
nikic wrote:
> Nice typo ;)
Sigh, i thought i only had this in next WIP patch, apparently i copied it from here :/


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63812/new/

https://reviews.llvm.org/D63812





More information about the llvm-commits mailing list