[PATCH] D60091: [test-suite] Signal error if llvm-lit was not found

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

In D60091#1559418 <https://reviews.llvm.org/D60091#1559418>, @lebedev.ri wrote:

> Uhm, that makes no sense.
>  How is that test runs, not via `check` target?


The builder is created by this rule:

  'factory' : ClangBuilder.getClangCMakeBuildFactory(jobs=4,
                                                     clean=False,
                                                     checkout_lld=False,
                                                     useTwoStage=False,
                                                     runTestSuite=True,
                                                     stage1_config='Release',
                                                     testsuite_flags=['--threads=4', '--build-threads=4'],
                                                     extra_cmake_args=["-DLLVM_ENABLE_ASSERTIONS=ON"]),

That code seems to pass in the pass to llvm-lit via the "--use-lit" argument to "lnt":

  lit = WithProperties('%(workdir)s/'+stage1_build+'/bin/llvm-lit')
  test_suite_cmd = [python, lnt, 'runtest', 'test-suite',
                    '--no-timestamp',
                    '--sandbox', sandbox,
                    '--test-suite', test_suite_dir,
                    '--cc', cc,
                    '--cxx', cxx,
                    '--use-lit', lit]

This code is from zorg/buildbot/builders/ClangBuilder.py in http://llvm.org/svn/llvm-project/zorg/trunk ... is this not how it's supposed to be used?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60091/new/

https://reviews.llvm.org/D60091