[PATCH] D60091: [test-suite] Signal error if llvm-lit was not found

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

In D60091#1559406 <https://reviews.llvm.org/D60091#1559406>, @uweigand wrote:

> This seems to have broken test-suite build bots?
>
> http://lab.llvm.org:8011/builders/clang-s390x-linux-lnt/builds/13870
>
>   CMake Error at CMakeLists.txt:220 (message):
>     llvm-lit not found.
>  
>     Make sure it is in your path or specify it via -DTEST_SUITE_LIT:FILEPATH=""
>  
>  
>
>
> The test suite seems to have executed correctly before this change brought in this error message ...


Uhm, that makes no sense.
How is that test runs, not via `check` target?



================
Comment at: test-suite/trunk/CMakeLists.txt:317-318
 get_property(TEST_SUITE_TARGETS GLOBAL PROPERTY TEST_SUITE_TARGETS)
 add_custom_target(check
   COMMAND ${TEST_SUITE_LIT} ${TEST_SUITE_LIT_FLAGS} .
   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
----------------
that is created here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60091/new/

https://reviews.llvm.org/D60091