[PATCH] D63827: [ARM] Allow MVE loads and stores of v2f64

Mikhail Maltsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 09:45:10 PDT 2019


miyuki marked an inline comment as done.
miyuki added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/mve-basic.ll:49
+entry:
+  %a.addr = alloca <16 x i8>, align 8
+  store <16 x i8> %a, <16 x i8>* %a.addr, align 8
----------------
ostannard wrote:
> You've added patterns for v2f64, but are testing v16i8.
> 
> Why are we getting stack re-alignment code, when the alloca only has 8-byte alignment?
> You've added patterns for v2f64, but are testing v16i8.
I'll add another test.

> Why are we getting stack re-alignment code, when the alloca only has 8-byte alignment?
Because `DataLayout::getPrefTypeAlignment` returns 16 for `<16 x i8>`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63827/new/

https://reviews.llvm.org/D63827





More information about the llvm-commits mailing list