[PATCH] D59909: [X86] Add custom isel to select ADD/SUB/OR/XOR/AND to their non-immediate forms under optsize when the immediate has additional users.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 08:35:24 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

I've chatted with @andreadb and other than taking the time and effort to create a separate pass to perform this generally we can't think of another way to do this. We do seem to be putting more and more strain on isel though....



================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4271
+
+    ConstantSDNode *Cst = dyn_cast<ConstantSDNode>(N1);
+    if (!Cst)
----------------
auto *Cst


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59909/new/

https://reviews.llvm.org/D59909





More information about the llvm-commits mailing list