[PATCH] D63762: [Object/invalid.test] - Convert most of the sub tests to YAML.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 05:23:50 PDT 2019


jhenderson added a comment.

Something odd has happened with the diff in this patch. It looks like you might have created it against the wrong thing?



================
Comment at: test/Object/invalid.test:129
+
+## Check that llvm-readobj reports an error if .dynsym has invalid sh_entsize.
+
----------------
"has an invalid" here and everywhere use using "has invalid"


================
Comment at: test/Object/invalid.test:259
+## Check that llvm-readobj reports an error when trying to dump sections
+## when the e_shnum field is broken (is greater than actual number of sections).
+
----------------
than the actual


================
Comment at: test/tools/yaml2obj/elf-header-sh-fields.yaml:4
 
-## First we check the default values.
+## At first we check the default values.
 
----------------
I think "First we..." was better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63762/new/

https://reviews.llvm.org/D63762





More information about the llvm-commits mailing list