[PATCH] D62806: [X86] X86DAGToDAGISel::matchBitExtract(): pattern c: truncation awareness

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Thank you for the review!



================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:3070
   // c) x &  (-1 >> (32 - y))
-  auto matchPatternC = [&checkOneUse, matchShiftAmt](SDValue Mask) -> bool {
+  auto matchPatternC = [&checkOneUse, &peekThroughOneUseTruncation, isAllOnes,
+                        matchShiftAmt](SDValue Mask) -> bool {
----------------
craig.topper wrote:
> The isAllOnes capture isn't used.
Hmm, indeed, thanks!


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:3271
                           &matchPatternC](SDValue Mask) -> bool {
     // FIXME: pattern c.
     return matchPatternA(Mask) || matchPatternB(Mask) || matchPatternC(Mask);
----------------
RKSimon wrote:
> should this still be here?
I think not :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62806/new/

https://reviews.llvm.org/D62806