[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 02:20:30 PDT 2019


courbet marked 6 inline comments as done.
courbet added a comment.

> I encourage adding small memcmp tests to test-suite as a follow-up, so we know that things won't break going forward.

I'm working on it.

> I haven't seen the DomTreeUpdater API before now, so I'm assuming the tests are verifying that we made the correct updates (and the earlier rL361239 <https://reviews.llvm.org/rL361239> has survived in trunk).

That was my first go at it too. Tests do break when I remove the updates, so I'm guessing they do :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60318/new/

https://reviews.llvm.org/D60318





More information about the llvm-commits mailing list