[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham marked 3 inline comments as done.
simon_tatham added inline comments.


================
Comment at: cfe/trunk/lib/Basic/Targets/ARM.cpp:912
+      return true;
+    }
   case 'U': // a memory reference...
----------------
craig.topper wrote:
> Is this supposed to fallthrough from 'T' to 'U'? If so can you add an LLVM_FALLTHROUGH
No, it wasn't supposed to; sorry about that. rL364380 has fixed it in a way that looks right to me.


================
Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:14098
     }
+
+  case 2:
----------------
craig.topper wrote:
> Is this supposed to fallthrough from case 1 to case 2?
No, and rL364376 looks like the right fix to me.


================
Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:14113
+    }
+
+  default:
----------------
craig.topper wrote:
> Is this supposed to fallthrough?
No, and rL364376 looks like the right fix to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60709/new/

https://reviews.llvm.org/D60709