[PATCH] D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses to ScopBuilder

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Could you clarify the title to make clear that it moves more than just the `finalizeAccesses` method, such as "Move finalizeAccesses and its callees to ScopBuilder"?



================
Comment at: polly/include/polly/ScopInfo.h:2284
+  /// Scop.
+  iterator_range<AccFuncVector::iterator> accessFunctions() {
+    return make_range(AccessFunctions.begin(), AccessFunctions.end());
----------------
I think iterator functions in LLVM use underscore_naming, such as `COFFObjectFile::base_relocs()`. The naming for this style would be `access_functions()`
This hasn't been documented I think, so I won't insist on it.


================
Comment at: polly/lib/Analysis/ScopInfo.cpp:2837
 
-Scop::~Scop() = default;
-
----------------
Unrelated change?


Repository:
  rPLO Polly

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63794/new/

https://reviews.llvm.org/D63794