[PATCH] D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 01:02:20 PDT 2019


yrouban marked 5 inline comments as done.
yrouban added inline comments.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch-profmd.ll:6
+
+; Test for a trivially unswitchable switch with multiple exiting cases and
+; multiple looping cases.
----------------
reames wrote:
> Given the control flow, you need at least one test case where we unswitch the default only, one where we unswitch cases only, and one where we do a combination of both.  
This advice revealed one case I missed to set weight for the default switch case. There were no branch in the original code for this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60606/new/

https://reviews.llvm.org/D60606





More information about the llvm-commits mailing list