[test-suite] r364388 - [test-suite] Signal error if llvm-lit was not found

[Roman Lebedev via llvm-commits]

Author: lebedevri
Date: Wed Jun 26 00:44:21 2019
New Revision: 364388

URL: http://llvm.org/viewvc/llvm-project?rev=364388&view=rev
Log:
[test-suite] Signal error if llvm-lit was not found

Summary:
I'm not sure if that was intentional or not?
I found it quite surprising when trying to integrate a new external project.

Reviewers: MatzeB, homerdin, hfinkel

Reviewed By: hfinkel

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60091

Modified:
    test-suite/trunk/CMakeLists.txt

Modified: test-suite/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/CMakeLists.txt?rev=364388&r1=364387&r2=364388&view=diff
==============================================================================
--- test-suite/trunk/CMakeLists.txt (original)
+++ test-suite/trunk/CMakeLists.txt Wed Jun 26 00:44:21 2019
@@ -90,7 +90,7 @@ if(TEST_SUITE_COLLECT_CODE_SIZE)
   mark_as_advanced(TEST_SUITE_LLVM_SIZE)
   if(TEST_SUITE_LLVM_SIZE STREQUAL "TEST_SUITE_LLVM_SIZE-NOTFOUND")
     message(FATAL_ERROR "llvm-size not found.
-Make sure it is in your path or set TEST_SUITE_COLLECT_CODE_SIZE to OFF")
+Make sure it is in your path or specify it via -DTEST_SUITE_LLVM_SIZE:FILEPATH=\"\" or set TEST_SUITE_COLLECT_CODE_SIZE to OFF")
   endif()
 endif()
 
@@ -107,7 +107,7 @@ if(TEST_SUITE_PROFILE_GENERATE)
   mark_as_advanced(TEST_SUITE_LLVM_PROFDATA)
   if(TEST_SUITE_LLVM_PROFDATA STREQUAL "TEST_SUITE_LLVM_PROFDATA-NOTFOUND")
     message(FATAL_ERROR "llvm-profdata not found.
-Make sure it is in your path or set TEST_SUITE_PROFILE_GENERATE to OFF")
+Make sure it is in your path or specify it via -DTEST_SUITE_LLVM_PROFDATA:FILEPATH=\"\" or set TEST_SUITE_PROFILE_GENERATE to OFF")
   endif()
 
   set(TEST_SUITE_PROFILE_GENERATE "True")
@@ -216,7 +216,10 @@ endif()
 find_program(TEST_SUITE_LIT NAMES "lit" "llvm-lit")
 set(TEST_SUITE_LIT_FLAGS "-sv" CACHE STRING "Flags used when running lit")
 mark_as_advanced(TEST_SUITE_LIT TEST_SUITE_LIT_FLAGS)
-mark_as_advanced(TEST_SUITE_LIT)
+if(TEST_SUITE_LIT STREQUAL "TEST_SUITE_LIT-NOTFOUND")
+  message(FATAL_ERROR "llvm-lit not found.
+Make sure it is in your path or specify it via -DTEST_SUITE_LIT:FILEPATH=\"\"")
+endif()
 
 add_subdirectory(tools)
 # Shortcut for the path to the fpcmp executable