[PATCH] D62818: [InstCombine] Introduce fold for icmp pred (and X, (sh signbit, Y)), 0.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 00:31:44 PDT 2019


lebedev.ri added a comment.

Is this the only remaining patch?
I don't think i should review my own code, perhaps @spatel can take a look?



================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:1796
+                                       m_LShr(m_Value(), m_Value()))),
+                       m_OneUse(m_Value(V0)))),
+                   m_CombineAnd(m_Zero(), m_Value(Zero)))) &&
----------------
I'm not sure why i have added `m_OneUse()` here, it should not be here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62818/new/

https://reviews.llvm.org/D62818





More information about the llvm-commits mailing list