[PATCH] D63703: [stack-safety] Refactoring StackSafetyAnalysis to be accsessible from other passes

[Gilang Mentari Hamidy via Phabricator via llvm-commits]

gilang marked an inline comment as done.
gilang added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:127
+    // namespace is no longer accessible directly when being passed with the
+    // refactored ParamInfo and AllocaInfo objects
+    using ::operator<<;
----------------
eugenis wrote:
> I'm not sure I understand this comment. Are the overloads for the new types shadowing the common overloads? Would it help to move them out of the anonymous namespace?
> 
> Btw, please upload change with full context, it's hard to review otherwise.
> See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Hi. Apologize for the inconvenience. I have updated the patch to include the full context.

So, without adding the using statement inside the block, the code will not compile due to overloading failure. Putting the operator overload declaration outside the anonymous namespace also does not help.

Clang used: 6.0.0-1ubuntu2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63703/new/

https://reviews.llvm.org/D63703