[PATCH] D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/COFF/Driver.cpp:1537
+  if (Config->Machine == I386 &&
+      Args.hasFlag(OPT_safeseh, OPT_safeseh_no, true))
+    Config->SafeSEH = true;
----------------
Should the default be off in the mingw case, if linking objects from gcc?


================
Comment at: lld/COFF/Writer.cpp:1431
+      // safeseh flag.
+      SetNoSEHCharacteristic = false;
+      continue;
----------------
Changing this flag for writing different output, right after flagging an error (which will, eventually, abort the writing?) feels a bit weird, but I guess it's good for completeness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63570/new/

https://reviews.llvm.org/D63570