[llvm] r364378 - Revert [llvm-objcopy][NFCI] Fix build failure with GCC

Rumeet Dhindsa via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 19:57:34 PDT 2019


Author: rdhindsa
Date: Tue Jun 25 19:57:34 2019
New Revision: 364378

URL: http://llvm.org/viewvc/llvm-project?rev=364378&view=rev
Log:
Revert [llvm-objcopy][NFCI] Fix build failure with GCC

This reverts r364263 (git commit 81eb82840524818ec0ec14285c866c09b9634df0)

This commit is related to r364254 which is causing some llvm-objcopy tests
to fail with valgrind.

Error:
Conditional jump or move depends on uninitialised value(s)

Modified:
    llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp

Modified: llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp?rev=364378&r1=364377&r2=364378&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp Tue Jun 25 19:57:34 2019
@@ -150,8 +150,6 @@ static Error executeObjcopyOnRawBinary(c
   case FileFormat::Unspecified:
     return elf::executeObjcopyOnRawBinary(Config, In, Out);
   }
-
-  llvm_unreachable("unsupported output format");
 }
 
 /// The function executeObjcopyOnBinary does the dispatch based on the format




More information about the llvm-commits mailing list