[PATCH] D63771: [yaml2obj] - Allow overriding e_shentsize, e_shoff, e_shnum and e_shstrndx fields in the YAML.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/yaml2obj/elf-header-sh-fields.yaml:1
+## In this test case we check that can override the default values for 
+## e_shentsize, e_shoff, e_shnum and e_shstrndx fields in the YAML.
----------------
that **we** can


================
Comment at: tools/yaml2obj/yaml2elf.cpp:212
+
+  Header.e_shentsize = Doc.Header.SHEntSize ? (uint16_t)(*Doc.Header.SHEntSize)
+                                            : sizeof(Elf_Shdr);
----------------
`(uint16_t)(*Doc.Header.SHEntSize)`

I think one of the pairs of `()` can be deleted..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63771/new/

https://reviews.llvm.org/D63771