[PATCH] D63696: [WebAssembly] Fix list of relocations with addends in lld

Keno Fischer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 17:28:31 PDT 2019


loladiro marked an inline comment as done.
loladiro added inline comments.


================
Comment at: lld/test/wasm/emit-relocs-fpic.ll:1
+# RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=obj -o %t.o < %s
+# RUN: llc --relocation-model=pic -filetype=obj %p/Inputs/ret32.ll -o %t.ret32.o
----------------
sbc100 wrote:
> Can you name this file .s since it contains asm?
> 
> (I think this is the first of the .s files tests in lld so you will also need to add .s to the list of suffixes in `lld/test/wasm/lit.local.cfg`)
Good catch. Meant to do that, but forgot. Will do and commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63696/new/

https://reviews.llvm.org/D63696





More information about the llvm-commits mailing list