[PATCH] D63694: [lld/WebAssembly] Slightly nicer error message for malformed input files

Keno Fischer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 16:22:44 PDT 2019


loladiro updated this revision to Diff 206547.
loladiro added a comment.

Remove extraneous output from error message and add test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63694/new/

https://reviews.llvm.org/D63694

Files:
  lld/test/wasm/corrupted.wasm.test
  lld/wasm/InputFiles.cpp


Index: lld/wasm/InputFiles.cpp
===================================================================
--- lld/wasm/InputFiles.cpp
+++ lld/wasm/InputFiles.cpp
@@ -52,7 +52,8 @@
                                        StringRef ArchiveName) {
   file_magic Magic = identify_magic(MB.getBuffer());
   if (Magic == file_magic::wasm_object) {
-    std::unique_ptr<Binary> Bin = check(createBinary(MB));
+    std::unique_ptr<Binary> Bin = CHECK(createBinary(MB),
+      MB.getBufferIdentifier());
     auto *Obj = cast<WasmObjectFile>(Bin.get());
     if (Obj->isSharedObject())
       return make<SharedFile>(MB);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63694.206547.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190625/bdd99eab/attachment.bin>


More information about the llvm-commits mailing list