[PATCH] D63788: llvm-c-test avoid calling malloc(0)

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 15:32:42 PDT 2019


hubert.reinterpretcast added a comment.

For a generic tool, this seems to be an okay fix; however, this is an API test driver. I would like to hear from other reviewers as to whether there is an intent to test the API for the `AttrCount == 0` case. If there is, then I believe that allocation should not be attempted, and the API should work with a null pointer.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63788/new/

https://reviews.llvm.org/D63788





More information about the llvm-commits mailing list