[PATCH] D63703: [stack-safety] Refactoring StackSafetyAnalysis to be accsessible from other passes
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 25 13:48:59 PDT 2019
eugenis added inline comments.
================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:127
+ // namespace is no longer accessible directly when being passed with the
+ // refactored ParamInfo and AllocaInfo objects
+ using ::operator<<;
----------------
I'm not sure I understand this comment. Are the overloads for the new types shadowing the common overloads? Would it help to move them out of the anonymous namespace?
Btw, please upload change with full context, it's hard to review otherwise.
See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63703/new/
https://reviews.llvm.org/D63703
More information about the llvm-commits
mailing list