[llvm] r364343 - [llvm-shlib] Do not use version script when building with MinGW

Pirama Arumuga Nainar via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 12:34:52 PDT 2019


Author: pirama
Date: Tue Jun 25 12:34:52 2019
New Revision: 364343

URL: http://llvm.org/viewvc/llvm-project?rev=364343&view=rev
Log:
[llvm-shlib] Do not use version script when building with MinGW

Summary:
The MinGW driver for lld does not support the --version-script option.
For GNU ld, it's a no-op since LLVM.dll exports all symbols.

Reviewers: srhines, mstorsjo

Subscribers: mgorny, fedor.sergeev, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D63743

Modified:
    llvm/trunk/tools/llvm-shlib/CMakeLists.txt

Modified: llvm/trunk/tools/llvm-shlib/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-shlib/CMakeLists.txt?rev=364343&r1=364342&r2=364343&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-shlib/CMakeLists.txt (original)
+++ llvm/trunk/tools/llvm-shlib/CMakeLists.txt Tue Jun 25 12:34:52 2019
@@ -55,7 +55,7 @@ if(LLVM_BUILD_LLVM_DYLIB)
 
     # GNU ld doesn't resolve symbols in the version script.
     set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)
-    if (NOT LLVM_LINKER_IS_SOLARISLD)
+    if (NOT LLVM_LINKER_IS_SOLARISLD AND NOT MINGW)
       # Solaris ld does not accept global: *; so there is no way to version *all* global symbols
       set(LIB_NAMES -Wl,--version-script,${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map ${LIB_NAMES})
     endif()




More information about the llvm-commits mailing list