[llvm] r364331 - [ARM] Support inline assembler constraints for MVE.
Simon Tatham via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 25 09:49:32 PDT 2019
Author: statham
Date: Tue Jun 25 09:49:32 2019
New Revision: 364331
URL: http://llvm.org/viewvc/llvm-project?rev=364331&view=rev
Log:
[ARM] Support inline assembler constraints for MVE.
"To" selects an odd-numbered GPR, and "Te" an even one. There are some
8.1-M instructions that have one too few bits in their register fields
and require registers of particular parity, without necessarily using
a consecutive even/odd pair.
Also, the constraint letter "t" should select an MVE q-register, when
MVE is present. This didn't need any source changes, but some extra
tests have been added.
Reviewers: dmgreen, samparker, SjoerdMeijer
Subscribers: javed.absar, eraman, kristof.beyls, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D60709
Added:
llvm/trunk/test/CodeGen/Thumb2/inlineasm-error-t-toofewregs-mve.ll
llvm/trunk/test/CodeGen/Thumb2/inlineasm-mve.ll
Modified:
llvm/trunk/docs/LangRef.rst
llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
llvm/trunk/test/CodeGen/ARM/inlineasm.ll
Modified: llvm/trunk/docs/LangRef.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/LangRef.rst?rev=364331&r1=364330&r2=364331&view=diff
==============================================================================
--- llvm/trunk/docs/LangRef.rst (original)
+++ llvm/trunk/docs/LangRef.rst Tue Jun 25 09:49:32 2019
@@ -3795,6 +3795,8 @@ All ARM modes:
- ``Q``, ``Um``, ``Un``, ``Uq``, ``Us``, ``Ut``, ``Uv``, ``Uy``: Memory address
operand. Treated the same as operand ``m``, at the moment.
+- ``Te``: An even general-purpose 32-bit integer register: ``r0,r2,...,r12,r14``
+- ``To``: An odd general-purpose 32-bit integer register: ``r1,r3,...,r11``
ARM and ARM's Thumb2 mode:
Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=364331&r1=364330&r2=364331&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Tue Jun 25 09:49:32 2019
@@ -14002,6 +14002,7 @@ ARMTargetLowering::getConstraintType(Str
} else if (Constraint.size() == 2) {
switch (Constraint[0]) {
default: break;
+ case 'T': return C_RegisterClass;
// All 'U+' constraints are addresses.
case 'U': return C_Memory;
}
@@ -14047,7 +14048,8 @@ using RCPair = std::pair<unsigned, const
RCPair ARMTargetLowering::getRegForInlineAsmConstraint(
const TargetRegisterInfo *TRI, StringRef Constraint, MVT VT) const {
- if (Constraint.size() == 1) {
+ switch (Constraint.size()) {
+ case 1:
// GCC ARM Constraint Letters
switch (Constraint[0]) {
case 'l': // Low regs or general regs.
@@ -14093,7 +14095,26 @@ RCPair ARMTargetLowering::getRegForInlin
return RCPair(0U, &ARM::QPR_VFP2RegClass);
break;
}
+
+ case 2:
+ switch (Constraint[0]) {
+ case 'T':
+ switch (Constraint[1]) {
+ default:
+ break;
+ case 'e':
+ return RCPair(0U, &ARM::tGPREvenRegClass);
+ case 'o':
+ return RCPair(0U, &ARM::tGPROddRegClass);
+ }
+ default:
+ break;
+ }
+
+ default:
+ break;
}
+
if (StringRef("{cc}").equals_lower(Constraint))
return std::make_pair(unsigned(ARM::CPSR), &ARM::CCRRegClass);
Modified: llvm/trunk/test/CodeGen/ARM/inlineasm.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/inlineasm.ll?rev=364331&r1=364330&r2=364331&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/inlineasm.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/inlineasm.ll Tue Jun 25 09:49:32 2019
@@ -48,3 +48,27 @@ entry:
%0 = tail call <4 x float> asm "vadd.f32 $0, $1, $2", "=t,t,t"(<4 x float> %a, <4 x float> %b)
ret <4 x float> %0
}
+
+define i32 @even-GPR-constraint() {
+entry:
+ ; CHECK-LABEL: even-GPR-constraint
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #1
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #2
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #3
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #4
+ %0 = tail call { i32, i32, i32, i32 } asm "add $0, #1\0Aadd $1, #2\0Aadd $2, #3\0Aadd $3, #4\0A", "=^Te,=^Te,=^Te,=^Te,0,1,2,3"(i32 0, i32 0, i32 0, i32 0)
+ %asmresult = extractvalue { i32, i32, i32, i32 } %0, 0
+ ret i32 %asmresult
+}
+
+define i32 @odd-GPR-constraint() {
+entry:
+ ; CHECK-LABEL: odd-GPR-constraint
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #1
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #2
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #3
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #4
+ %0 = tail call { i32, i32, i32, i32 } asm "add $0, #1\0Aadd $1, #2\0Aadd $2, #3\0Aadd $3, #4\0A", "=^To,=^To,=^To,=^To,0,1,2,3"(i32 0, i32 0, i32 0, i32 0)
+ %asmresult = extractvalue { i32, i32, i32, i32 } %0, 0
+ ret i32 %asmresult
+}
Added: llvm/trunk/test/CodeGen/Thumb2/inlineasm-error-t-toofewregs-mve.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/inlineasm-error-t-toofewregs-mve.ll?rev=364331&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Thumb2/inlineasm-error-t-toofewregs-mve.ll (added)
+++ llvm/trunk/test/CodeGen/Thumb2/inlineasm-error-t-toofewregs-mve.ll Tue Jun 25 09:49:32 2019
@@ -0,0 +1,14 @@
+; RUN: not llc -mtriple=armv8.1-m-eabi -mattr=+mve %s -o /dev/null 2>&1 | FileCheck %s
+
+; CHECK: inline assembly requires more registers than available
+define arm_aapcs_vfpcc <4 x i32> @t-constraint-i32-vectors-too-few-regs(<4 x i32> %a, <4 x i32> %b) {
+entry:
+ %0 = tail call { <4 x i32>, <4 x i32>, <4 x i32>, <4 x i32>, <4 x i32>,
+ <4 x i32>, <4 x i32>, <4 x i32>, <4 x i32>, <4 x i32> }
+ asm "",
+ "=t,=t,=t,=t,=t,=t,=t,=t,=t,=t,t,t"(<4 x i32> %a, <4 x i32> %b)
+ %asmresult = extractvalue { <4 x i32>, <4 x i32>, <4 x i32>, <4 x i32>,
+ <4 x i32>, <4 x i32>, <4 x i32>, <4 x i32>,
+ <4 x i32>, <4 x i32> } %0, 0
+ ret <4 x i32> %asmresult
+}
Added: llvm/trunk/test/CodeGen/Thumb2/inlineasm-mve.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/inlineasm-mve.ll?rev=364331&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Thumb2/inlineasm-mve.ll (added)
+++ llvm/trunk/test/CodeGen/Thumb2/inlineasm-mve.ll Tue Jun 25 09:49:32 2019
@@ -0,0 +1,48 @@
+; RUN: llc -mtriple=armv8.1-m-eabi -mattr=+mve %s -o - | FileCheck %s
+
+define i32 @test1(i32 %tmp54) {
+ %tmp56 = tail call i32 asm "uxtb16 $0,$1", "=r,r"( i32 %tmp54 )
+ ret i32 %tmp56
+}
+
+define void @test2() {
+ tail call void asm sideeffect "/* number: ${0:c} */", "i"( i32 1 )
+ ret void
+}
+
+define arm_aapcs_vfpcc <4 x i32> @mve-t-constraint-128bit(<4 x i32>, <4 x i32>) {
+; CHECK-LABEL: mve-t-constraint-128bit
+; CHECK: vadd.i32 q{{[0-7]}}, q{{[0-7]}}, q{{[0-7]}}
+ %ret = tail call <4 x i32>
+ asm "vadd.i32 $0, $1, $2", "=t,t,t"
+ (<4 x i32> %0, <4 x i32> %1)
+ ret <4 x i32> %ret
+}
+
+define i32 @even-GPR-constraint() {
+entry:
+ ; CHECK-LABEL: even-GPR-constraint
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #1
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #2
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #3
+ ; CHECK: add [[REG:r1*[0, 2, 4, 6, 8]]], [[REG]], #4
+ %0 = tail call { i32, i32, i32, i32 }
+ asm "add $0, #1\0Aadd $1, #2\0Aadd $2, #3\0Aadd $3, #4\0A", "=^Te,=^Te,=^Te,=^Te,0,1,2,3"
+ (i32 0, i32 0, i32 0, i32 0)
+ %asmresult = extractvalue { i32, i32, i32, i32 } %0, 0
+ ret i32 %asmresult
+}
+
+define i32 @odd-GPR-constraint() {
+entry:
+ ; CHECK-LABEL: odd-GPR-constraint
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #1
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #2
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #3
+ ; CHECK: add [[REG:r1*[1, 3, 5, 7, 9]]], [[REG]], #4
+ %0 = tail call { i32, i32, i32, i32 }
+ asm "add $0, #1\0Aadd $1, #2\0Aadd $2, #3\0Aadd $3, #4\0A", "=^To,=^To,=^To,=^To,0,1,2,3"
+ (i32 0, i32 0, i32 0, i32 0)
+ %asmresult = extractvalue { i32, i32, i32, i32 } %0, 0
+ ret i32 %asmresult
+}
More information about the llvm-commits
mailing list