[lld] r362743 - Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the sections were discarded""

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 08:48:50 PDT 2019


Okay, I've reverted in r364321 (see commit message for details),
hopefully avoiding any breakages.

On Tue, Jun 25, 2019 at 5:19 PM Sean Fertile <sfertile at ca.ibm.com> wrote:
>
>
> The original commit broke the PowerPC lld multistage buildbot, I don't think our buildbot monitor opened a bugzilla issue so I have nothing to direct you to. My reverting the commit broke the X86 buildbots and I didn't have an X86 machine handy to test what broke so I reverted my revert and left the PowerPC buildbot broken until the original author could land a proper fix. That proper fix landed in https://reviews.llvm.org/rLLD363126.
>
>
> ----- Original message -----
> From: Hans Wennborg <hans at chromium.org>
> To: Sean Fertile <sfertile at ca.ibm.com>
> Cc: llvm-commits <llvm-commits at lists.llvm.org>
> Subject: [EXTERNAL] Re: [lld] r362743 - Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the sections were discarded""
> Date: Tue, Jun 25, 2019 9:11 AM
>
> On Thu, Jun 6, 2019 at 10:13 PM Sean Fertile via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > Author: sfertile
> > Date: Thu Jun  6 13:16:53 2019
> > New Revision: 362743
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=362743&view=rev
> > Log:
> > Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the sections were discarded""
> >
> > This reverts commit 729111cf1824159bb4dd331cab8a829eab30313f.
> >
> > Reverting the previous commit breaks other LLD buildbots.
>
> This series of commits is very hard to follow.
>
> Do you have a pointer to what broke?
>
>
>
>


More information about the llvm-commits mailing list