[PATCH] D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

[Clement Courbet via Phabricator via llvm-commits]

courbet marked an inline comment as done.
courbet added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/X86/memcmp.ll:749-754
+define i1 @length16_eq(i8* %x, i8* %y) nounwind {
+; X86-NOSSE-LABEL: length16_eq:
+; X86-NOSSE:       # %bb.0:
+; X86-NOSSE-NEXT:    pushl $0
+; X86-NOSSE-NEXT:    pushl $16
+; X86-NOSSE-NEXT:    pushl {{[0-9]+}}(%esp)
----------------
spatel wrote:
> Why/how are we checking x86 asm in an IR transform test file?
> 
> I don't think there's a good way to do end-to-end testing now within the regression test dir. 
> 
> We would be better off creating real end-to-end (C source --> x86 asm) tests within test-suite? That way, we can be sure that no passes anywhere in the pipeline are interfering with our memcmp patterns.
Right, I think I messed up updating the tests, sorry. The intent was to check for IR here. Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60318/new/

https://reviews.llvm.org/D60318