[PATCH] D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 04:36:38 PDT 2019


ro created this revision.
ro added reviewers: kcc, samsonov.
Herald added subscribers: Sanitizers, llvm-commits, fedor.sergeev, dberris, kubamracek.
Herald added projects: LLVM, Sanitizers.

While checking warnings from the Solaris buildbots, I noticed

  llvm-lit: /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/projects/compiler-rt/test/asan/lit.cfg:119: warning: %shared_libasan substitution not set but dynamic ASan is available.

Fixed as follows.  Tested on `x86_64-pc-solaris2.11`.  Ok for trunk?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D63761

Files:
  lib/sanitizer_common/sanitizer_solaris.cc


Index: lib/sanitizer_common/sanitizer_solaris.cc
===================================================================
--- lib/sanitizer_common/sanitizer_solaris.cc
+++ lib/sanitizer_common/sanitizer_solaris.cc
@@ -88,11 +88,6 @@
   return _REAL64(open)(filename, flags, mode);
 }
 
-uptr OpenFile(const char *filename, bool write) {
-  return ReserveStandardFds(
-      internal_open(filename, write ? O_WRONLY | O_CREAT : O_RDONLY, 0660));
-}
-
 DECLARE__REAL_AND_INTERNAL(uptr, read, fd_t fd, void *buf, uptr count) {
   return _REAL(read)(fd, buf, count);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63761.206414.patch
Type: text/x-patch
Size: 561 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190625/7aa52e0f/attachment.bin>


More information about the llvm-commits mailing list